[fix] [ml] Fix cursor metadata compatability issue when switching the config unackedRangesOpenCacheSetEnabled #23759
Conversation
… config unackedRangesOpenCacheSetEnabled
poorbarcode
added
type/bug
poorbarcode
requested review from
lhotari,
rdhabalia,
Technoboy-,
codelipenghui,
gaoran10 and
shibd
|
/pulsarbot rerun-failure-checks |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23759 +/- ##
============================================
+ Coverage 73.57% 74.13% +0.56%
+ Complexity 32624 31763 -861
============================================
Files 1877 1853 -24
Lines 139502 143391 +3889
Branches 15299 16279 +980
============================================
+ Hits 102638 106308 +3670
+ Misses 28908 28705 -203
- Partials 7956 8378 +422
Flags with carried forward coverage won't be shown. Click here to find out more.
|
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
Show resolved
Hide resolved
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Thanks for the contribution, @poorbarcode . This is an essential improvement.
I'd like to request a change for the default value of managedLedgerPersistIndividualAckAsLongArray. It should be set to true in this PR. There's a long mailing list thread about this:
https://lists.apache.org/thread/kfm7n6xf9pf7h76k4gx83zv3c2kj6yy1
When we say there's support for downgrading (rollback), it doesn't
mean users don't need to take any action.
We ensure downgrade compatibility by providing an upgrade guide that
explains how to configure the system to allow rollbacks without losing
state information. If we didn't do this, we'd always be stuck in the
same situation whenever a new LTS version comes out.
Let's start making progress:
- keep PR 9292 as default
- implement PR 23759 without changing the PR 9292 default
- write a proper upgrade guide for Pulsar 4.0 where rollback
considerations are explained (separate PR)
|
Answered your question in the discussion channel: https://lists.apache.org/thread/kfm7n6xf9pf7h76k4gx83zv3c2kj6yy1 |
|
Hi Lari Since there is no more arguments in the email list, I dismissed your change request |
poorbarcode
dismissed
lhotari’s stale review
[DISCUSS] Add an optional config to disable the feature that compresses cursor metadata, which was contributed by #9292
@poorbarcode In Apache projects, we continue discussions until there's consensus on important decisions. We haven't reached consensus yet. Let's postpone cherry-picking to branch-4.0 until there's consensus. |
Motivation
unackedRangesOpenCacheSetEnabled. You can reproduce the issue with the new testtestUnackmessagesAndRecoveryCompatibilityModifications
managedLedgerPersistIndividualAckAsLongArrayto enable or disable the feature that [fix][broker] Support large number of unack message store for cursor recovery #9292 introduced, and set the default value tofalse.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x